Daniel Karzel

Results 41 issues of Daniel Karzel

Follow up of https://github.com/comit-network/xmr-btc-swap/pull/405 Try to save information received for a swap that is currently not in execution into the database so it is not lost (i.e. the other party...

## What happened * Start swap between CLI on laptop and ASB on raspberry, branch `no-transfer-proof-failure`, commit `facab99b8af6b2bebd15096c2f324c8460e9089d` * Swap got stale waiting for transfer proof on the CLI (ASB...

bug
cli

Here is a run where the build fails due to the monero wallet RPC not being available properly: https://github.com/comit-network/xmr-btc-swap/runs/2652333552 It is unclear what exactly causes this, but from the logs...

Currently it can happen that swap CLI user send BTC to a mainnet swap CLI, but the swap is rejected because the ASB runs on testnet. The BTC then sits...

When looking at the ASB logs I noticed that it seems dropping the subscriptions for Bitcoin transactions does not work properly: Logs: ``` ... Jun 02 01:10:47 raspberrypi asb[11062]: DEBUG...

Scenario: * CLI locked Bitcoin * ASB sends XMR lock trasaction but the transaction is rejected. wallet RPC log: ``` 2021-05-24 08:55:47.842 E daemon_send_resp.status != CORE_RPC_STATUS_OK. THROW EXCEPTION: error::tx_rejected ```...

Goal is to remove all the functions from the state to keep the state as pure data without functionality. The functions could be moved to the `swap` module. Some of...

tech-debt

With https://github.com/comit-network/xmr-btc-swap/pull/451 we added yet another logic element to the event loop. This makes it hard to test and extend the code. We should decompose those elements into separate components...

tech-debt

Currently, when resuming a swap we do not re-try dialing Alice if we fail to dial her initially. This means, the user would have to ensure to restart the application...

cli

Secure the ASB wallet with a password that is derived from the asb `seed`. That way one cannot just access the wallet. Note that if we do that (to tighten...

asb