Daniel Karzel

Results 33 comments of Daniel Karzel

Is this going to be merged any time soon? It seems to be approved.

In the issue description you mention that the CLI is restarted and you > Resume the swap > -> Error occurs. Swap is not automatically refunded. Bob will get punished...

Only idea so far: Might be a nonce issue because the ASB wallet is used on the raspberry and locally.

Concerning Monero wallet RPC: Unfortunately this is not as easy to add as it seems. Monero wallet RPC uses digest auth, so we would have to properly generate the digest...

Can get inspiration from extracting Alice's `spot_price` behaviour in #461 - this removed a good deal of logic from the eventloop and made it testable with network protocol level tests.

If someone ever picks this up read this: https://github.com/comit-network/xmr-btc-swap/pull/507#discussion_r633953991

Note: The wallet RPC will only pick up the transaction once it has one confirmation. Hence waiting for one confirmation for better usability.

I opened the wallet from `keys` file only (which re-scans) and the balance is actually `0`. I did another `rescan_blockchain` once the wallet was opened and the balance remains `0`....

CLI logs of the initial run: ``` Running `target/debug/swap --testnet --debug --data-dir /Users/dakami/TEMP/swap/bob/01 buy-xmr --receive-address 58hKkN5JrirdNehmTXaHhTEg3N5zRYZ6Wb5g5jwDk3wRC4rtNCJvx7hENsbLmfPakC3spGhciosagdVbSqq9vfXsV3zusCn --seller-addr /ip4/141.168.172.35/tcp/8765 --seller-peer-id 12D3KooWPZ69DRp4wbGB3wJsxxsg1XW1EVZ2evtVwcARCF3a1nrx` 2021-05-25 19:36:11 INFO Initialized tracing level=debug 2021-05-25 19:36:11 DEBUG Opening...