Charlie Gu
Charlie Gu
hey @baumandm, a quick question about this feature. Have you consider to add some authorization check on the query engine side to throw errors if the user cannot run the...
ah got it, just for the sake of brainstorming, what if we add a field called `disabled` into QueryEngine which could be set by admins that would not allow users...
sounds good, how about lets use user_query_engine env as denylist when engine is enabled then?
hey @robshep have you tried other browsers see similar issue? I just tested on Firefox 100 on Mac and there is no error there
yup this sounds like a great idea!
hey @baumandm , this PR lgtm and we can merge it. One last thing I want to mention is that we might make modifications for this feature in future, and...
@baumandm would it be possible to additional features in another PR since the current code is pretty good as is 🙏 ? The adhoc editor setting would be stored in...
i was thinking to make it like Superset's limit:  also to prevent users from abusing the limit, i guess we gotta think of solutions to transform the query in...
so we are actually facing a similar issue at Pinterest. I am leaning towards option 2. We can have another loader that completely replaces HMSMetastoreLoader and just load the table...
hey @sakshamsaxena06984 what kind of errors are you seeing? can you provide the stack trace?