Christopher Tubbs

Results 512 comments of Christopher Tubbs

Also, keep in mind GNU has two formats, one for text mode input (`${digest}${filename}`) and one for binary mode input (`${digest}${filename}`) (although, in practice, they are equivalent on GNU systems).

Reminder: please set the Project version(s) when merging PRs, so we can track the fix version for changes.

> Depending on which PR is merged first, the properties changed here should match the design set in #2190. I'll finish reviewing #2190 so we can get that in first,...

@milleruntime I'd like to take another look at this soon, but it seems to be a little out of date right now. Want to rebase it?

> @ctubbsii I re-base'd my per-table crypto changes again with latest for 2.1. Did you want to take another look at this PR before I rewrite the tests? I do...

> > It's weird to ask for eventual consistency. Nobody wants eventual consistency. Eventual consistency is always tolerated, never desired. > > Eventual consistency for reads is desired in this...

> Using `set/getConsistencyLevel` on ScannerBase allows us to change the implementation without changing the API. Using a name tied to the implementation will cause API churn if the implementation changes....

I'm thinking it would be better to leverage the scan hints to control a ScanServer-aware dispatcher, rather than add a new API for the consistency level.

> > I'm thinking it would be better to leverage the scan hints to control a ScanServer-aware dispatcher, rather than add a new API for the consistency level. > >...

@keith-turner wrote: > > It's not the scan execution hints that are modifying the behavior... it's the configured dispatcher. And, the scan hints are still not affecting the data returned......