Grant Kinney

Results 90 comments of Grant Kinney

Note that specifying the name of a style variation is missing in the Site editor interface, from a report on the support forums https://github.com/WordPress/create-block-theme/issues/559

Related to https://github.com/WordPress/create-block-theme/issues/466

> I've explored this a little bit more and I haven't found a way of defining the constant in a plugin. Now that you mention it, I'm sure that's by...

> I think this is not accurate because the plugin changes the content of the theme.json file on the disk when the option Save theme changes is used. Yes, that's...

The font face `src` property can be an array or string, [both are specified in the theme.json schema](https://github.com/WordPress/gutenberg/blob/trunk/schemas/json/theme.json#L699), so create-block-theme needs to be updated to support either.

I'm exploring a fix for this and https://github.com/WordPress/gutenberg/issues/51667 over in https://github.com/WordPress/gutenberg/pull/62669. I didn't take on any refactoring, instead trying to resolve this issue with minimal changes while trying to not...

This is a flyby comment, so forgive me if I'm missing context. We already have the convention of using `file:./path/to/file.ext` for `settings.typography.fontFamilies.fontFace.src`. Would it make sense to use `file:./` prefix...

Here's my variation on a typescript definition file, in case you want to specify what kind of string is output. ```typescript declare module "docuri" { interface Route { // parse...

> ...do you remember why the (temp) filter `add_filter( 'upload_mimes', array( 'WP_Font_Utils', 'get_allowed_font_mime_types' ) );` in `handle_font_file_upload()` was needed? The same array of allowed mime types is already passed to...