Grant Kinney
Grant Kinney
Thanks for the reviews and assist. I'll set this to merge once tests pass.
I just cherry-picked this PR to the release/17.8 branch to get it included in the next release: 1b5ae3c5a0
Note that I'm pulling out the UI permissions checks from https://github.com/WordPress/gutenberg/pull/59294 into https://github.com/WordPress/gutenberg/pull/59332, so I've changed the base branch of this PR to `update/font-library-ui-permissions`
I'm not fully convinced customized font post permissions deserve e2e tests (coming from the philosophy that e2e tests are expensive and generally saved for the most important flows). Is there...
> I believe the main permissions that are specific to managing fonts are: > - The ability to create new posts in the database, storing the font face/family definition >...
I put together an experimental PR for another way we could handle respecting `DISALLOW_FILE_MODS` - Prevent uploading fonts when `DISALLOW_FILE_MODS` is set to true or the fonts dir is not...
@peterwilsoncc Thanks for taking another look at this issue and reviewing the PR--I'll work on updating the PR tomorrow. > As WordPress 6.5 is in it's final stages, I think...
Here's a PR that combines approaches, adding a meta capability for `upload_fonts`, as well as capability checks in the UI for font creation/deletion. Please review! https://github.com/WordPress/gutenberg/pull/59294
Reviewing the above conversation about whether a new capability is needed for uploading fonts seems to hinge on how you categorize font uploads: are they more like media uploads or...
@vcanales and I are planning to take a look at what tooling would need to be added to support deploying individual block plugins from the Gutenberg repo. Some initial thoughts...