Joe Fehrman

Results 11 issues of Joe Fehrman

Using the example on the README.md file would it be possible to write an endpoint that searches based on a partial string? For instance could I query like `/english/action/action?name=dea` and...

Hey would it be ok if we introduced a jsonconfig.json? This would allow tsserver the LSP to better enforce typesafety in the code base. It basically allows your editor to...

This PR attempts to add some additional comments in JSDoc to improve typesafety as well as attempt to draw attention to certain areas where previously unexpected bugs could occur. We...

refactor: Refactoring the name for dataFeedCache to be engageDestinationCache. This is because this cache is no longer just intended to be used for DataFeed cache, but is now intended to...

partner-eng-review (cloud)
mode:cloud
actions:core
team:segment

_Updating version of liquidjs._ https://segment.atlassian.net/browse/CHANNELS-1084 ## Testing _Should be a transparent yarn test command to ensure the functionality continues to work as expected. Based on coverage reports running the code...

Ready for Release
partner-eng-review (cloud)
team:segment

Renaming the onConfirmDisabled property in AlertDialog to be isConfirmDisabled so that the property is more transparent how it should be used. onConfirmDisabled reads more like it expects a function. isConfirmDisabled...

size:S

### Description When I inspect the HTML of the combobox output I expect to see: * An input with the role of select (or maybe button?). * A role of...

Type: Bug
Status: Pls CR
Area: Components

The purpose of this Pull Request is to add some [JSDoc](https://jsdoc.app/) to the Account Switcher, Alert, and Alert Dialog components. There are a few minor refactors that accompany this Pull...

size:L
Contribution

### Description When I use the alert dialog component, I expect that it will utilize the built in dialog element, instead it is using a bunch of divs in order...

Type: Enhancement
Status: WIP
Area: Components

### Description When I tab to a combobox component, press down to open the menu, and press spacebar over the option I want to select, the web page scrolls. I...

Area: Components