twilio-labs
on-confirm-disabled-rename
Renaming the onConfirmDisabled property in AlertDialog to be isConfirmDisabled so that the property is more transparent how it should be used. onConfirmDisabled reads more like it expects a function. isConfirmDisabled reads more like it expects a boolean. #3901
Contributing to Twilio
All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.
- [X] I acknowledge that all my contributions will be made under the project's license.
![bolt-new-by-stackblitz[bot] avatar](https://avatars.githubusercontent.com/in/182710?v=4 "Published by a pub.dev verified publisher"){kind=small}
🦋 Changeset detected
Latest commit: 51544f8abfa24e51b434445f6f3bbd625e9fd106
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
| Name | Type |
|---|---|
| @twilio-paste/alert-dialog | Patch |
| @twilio-paste/core | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
@cogwizzle is attempting to deploy a commit to the Twilio Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 51544f8abfa24e51b434445f6f3bbd625e9fd106. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 3 targets
Sent with 💌 from NxCloud.
![nx-cloud[bot] avatar](https://avatars.githubusercontent.com/in/80458?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 51544f8abfa24e51b434445f6f3bbd625e9fd106:
| Sandbox | Source |
|---|---|
| @twilio-paste/nextjs-template | Configuration |
| @twilio-paste/token-contrast-checker | Configuration |
![codesandbox-ci[bot] avatar](https://avatars.githubusercontent.com/in/38409?v=4 "Published by a pub.dev verified publisher"){kind=small}
yarn run changeset
Let me give this a shot first. Thanks so much for reminding me. I'm still a bit new here. :)
@nkrantz I think we should be in good shape now. Can you verify the update?
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| paste-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 22, 2024 3:33pm |
| paste-remix | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 22, 2024 3:33pm |
Thanks for making those changes @cogwizzle!
Did you run any commands other than yarn buid:typedocs? Somehow you got a bunch of other packages' types wrapped up in this PR, haven't seen that before. Might suggest removing the changes you didn't intend to make, then re-running the command. Otherwise looks great!
Thanks for making those changes @cogwizzle!
Did you run any commands other than
yarn buid:typedocs? Somehow you got a bunch of other packages' types wrapped up in this PR, haven't seen that before. Might suggest removing the changes you didn't intend to make, then re-running the command. Otherwise looks great!
I regenerated the types and it came up the same. It appears to mostly be a change in order on some of the types. Nothing major.
I regenerated the types and it came up the same. It appears to mostly be a change in order on some of the types. Nothing major.
Though most of them are just re-orders there are also a few actual additions and removals of props. I made the Alert Dialog changes on my end and generated type docs and only saw the Alert Dialog types modified. I don't feel great about merging these additional type changes (especially the removals) without understanding why they happened on your branch. The type check is also failing (PR Checks / Build system packages and type check). I'm going to look into this today and think about why yarn build:typedocs might not be working for you. Sorry about the delay with getting this PR in.