codex
codex
Not moving to examples, certainly, but moving to `jme3-plugins` might be a good idea. I've personally been very busy lately, so I do not have the time to do this...
> I want to be clear that this isn't a criticism of your contribution, but rather a collaborative effort to improve the engine. Yes, I realize this, and thank you....
Ok, I restored as much as I could, but there are still some "changes" left I can't figure out how to restore.
Hey @capdevon, would you mind taking another look at this? I have reverted all the changes that I could. There are still some unnecessary changes, but I couldn't figure out...
> I would recommend investing some time in learning Maven or Gradle to ensure your example projects (Renthyl) are compilable. I attempted to use Gradle on Renthyl, but Gradle did...
@zzuegg how close are you to finishing the review?
If I'm being totally honest, GeometryRenderHandler is mostly a Renthyl leak. The reason I originally kept it in the PR, is I thought it would be generally useful for people...
> The only thing I'd suggest adding is keyTriggers or buttons for toggling things like bloom, shadows, ssao, etc etc. I deliberately chose not to do this because the graphical...
> I'm not a big fan of this monolithic approach, as similar solutions tend to be complex to maintain and evolve over time TestSceneBuilder is monolithic on purpose. The idea...
> This also leads me to ask: is that how you would best intend someone to use TestSceneBuilder for writing a demo? My plan was to create a new class...