Ganesh Vernekar
Ganesh Vernekar
It is in 2.39.x
> @codesome Is there a reason why the WAL watcher couldn't use fsnotify for WAL segments? Alternatively I could pass a channel to the WAL watcher to inform it when...
Lots of travel got in the way. I will take a look at it this month. Apologies for the wait!
Oh, I see it now. We will trigger the function everytime Compact() is called, and does not depend on compaction happening. I would suggest moving that call inside `DB.run()`, and...
/prombench main One last benchmark after some recent changes.
/prombench restart main
Closing as per the above comment. If you have any more issues, please open another issue with details.
Converted this to draft since it requires changes to `pkg/storage`. I will open a PR for that first (Edit: PR for that https://github.com/grafana/mimir/pull/4354).
Another suggestion: The function could be just `.Timestamp()`, and similarly if you have to access, it could be `.Histogram()`, `.FloatHistogram()`, and `.Float()` or `.FloatVal()`if you prefer.
Prometheus also uses functions like `T() V() H() FH()` in some interfaces. (We don't use `Get` prefix). But I leave it up to you.