Ganesh Vernekar

Results 169 comments of Ganesh Vernekar

Step 1: Adding backward compatibility to v2.55 https://github.com/prometheus/prometheus/pull/14934

If we do this change in 3.0, users will only be able to downgrade to 2.55 and not before. This is not a friendly scenario. So I will do this...

In your comparison charts, the CPU is spiking higher. And as I understand, CPU is much more expensive than giving a little more memory. Can you please check what is...

_Something_ happened. This PR started to behave weirdly after some point. @alanprot could you investigate what happened? Before the anomaly, there is a slight increase in CPU with no impact...

I think we store metadata in the memory right now but do not persist it. One idea I have for persisting is, in the [Series entry](https://github.com/prometheus/prometheus/blob/main/tsdb/docs/format/index.md#series) of the block index,...

We (at Reddit) are interested in this and will be investing time in coming weeks/months to get a design doc out and contribute the code.

PTAL at the design doc for this: [Early Compaction of Stale Series from the Head Block](https://github.com/prometheus/proposals/pull/55). The doc mostly talks about some high level topics, like tracking stale series and...

Another occurrence https://github.com/grafana/mimir/actions/runs/11188014503/job/31106091993?pr=9515 FAIL: TestPartitionReader_ConsumeAtStartup ``` ================== WARNING: DATA RACE Write at 0x00c00091f160 by goroutine 44209: github.com/twmb/franz-go/pkg/kgo.(*cursor).setOffset() /__w/mimir/mimir/vendor/github.com/twmb/franz-go/pkg/kgo/source.go:284 +0x7a8 github.com/twmb/franz-go/pkg/kgo.(*cursor).unset() /__w/mimir/mimir/vendor/github.com/twmb/franz-go/pkg/kgo/source.go:259 +0x765 github.com/twmb/franz-go/pkg/kgo.(*consumer).assignPartitions() /__w/mimir/mimir/vendor/github.com/twmb/franz-go/pkg/kgo/consumer.go:1025 +0x757 github.com/twmb/franz-go/pkg/kgo.(*Client).RemoveConsumePartitions() /__w/mimir/mimir/vendor/github.com/twmb/franz-go/pkg/kgo/consumer.go:874 +0x544 github.com/grafana/mimir/pkg/storage/ingest.(*PartitionReader).switchToOngoingFetcher() /__w/mimir/mimir/pkg/storage/ingest/reader.go:280...

Given the index cannot go beyond 64G at the moment, and that not all index is loaded into memory at once, I guess it should be fine. The user should...