Adrian Cole

Results 419 issues of Adrian Cole

AnnotationBlock is a bit confusing to me. Primarily, it encapsulates the duration between send and receive or visa versa. This is the same as Span. For example, Span with kind...

https://github.com/reiseburo/hermann has been dead for over 2 years and requires jruby https://github.com/zendesk/ruby-kafka looks very active

techdebt

As discussed on https://github.com/openzipkin/b3-propagation/issues/21 and first implemented here: https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/propagation/B3SingleFormat.java https://github.com/openzipkin/brave/blob/master/brave/src/test/java/brave/propagation/B3SingleFormatTest.java Let's support at least reading "b3" header from a single string, most commonly traceid-spanid-1 It would also be nice to...

Zipkin's RPC span is interesting because it is a shared model. For example, a client creates a span and then the next hop (a server) adds annotations to it. The...

We currently support logging of only IPv4 addresses. Starting with Zipkin 1.4 endpoints can omit IPv4 (by setting Endpoint.ipv4 to 0), and optionally log Endpoint.ipv6 as the raw 16byte address....

Zipkin's v2 format is a lot easier to parse (eventhough in reality it will take a while for instrumentation to start using it). It might be worthwhile supporting: openzipkin/zipkin#1684

per https://github.com/openzipkin/zipkin-gcp/issues/42#issuecomment-379859937 We should highlight that this code (which ends up in the openzipkin/zipkin-gcp docker image) replaces the preceding `gcr.io/stackdriver-trace-docker/zipkin-collector`, but it is different. Primarily, the stackdriver module here is...

During #119, we noticed there's still a dependency on google's oauth library which is getting subverting our dependency management. What's happening is it has not only a strict dep on...

enhancement

ZipkinStackdriverStorageModule is using the only internal type not yet shaded. io.netty.util.internal.PlatformDependent As internally, this checks for android which won't be the case in spring boot. then it seems to just...

enhancement

Via #150, we are currently downloading zipkin-server via Jitpack. There were some questions about if this is reliable, or if the lazy build of the server notably impacts master performance...