Adrian Cole

Binary encoding

1

Some are concerned about the relative costs of a hex-encoded format vs a binary one. Some of them are justifiable eventhough there is a large ecosystem impact to defining a...

Define what behavior is expected when X-B3-TraceId is present, but not X-B3-SpanId

19

question here https://github.com/spring-cloud/spring-cloud-sleuth/issues/400#issuecomment-246866057 from @shalako

Add section on single-host patterns

1

Make sure it is clear how to do single-host spans in B3. In short, you take the propagated trace context as the parent context. As soon as you receive the...

How does a caller figure out the trace id of a request?

13

For debugging or (log) correlation reasons, a user might want to know what the trace id is of a request. Since X-B3 headers are request headers (not response headers), how...

What should a trace id and span id look like?

6

from a question: https://github.com/spring-cloud/spring-cloud-sleuth/issues/400#issuecomment-246878146

Spans view doesn't work with zipkin

4

We get a needle not found when clicking on the spans view for a zipkin trace.

please enhance to work with messaging traces

2

In testing zipkin we noticed that a messaging trace doesn't render. Here is it in zipkin The data is messaging2.json here https://github.com/openzipkin/zipkin/tree/master/zipkin-ui/testdata In Haystack it doesn't look so hot :)

Problems around the new io.opentracing.tag.Tag api

10

While I can't quite trace the background for it, `io.opentracing.tag.Tag` appears to have been added last week. There are a number of problems around it, which I'll catalog here: 1....

While traceId and spanId were recently added to the `SpanContext` type, routine properties used including parentSpanId and sampling status were left out. I can cite code back to at least...

Deprecate or remove `ScopeManager.active()`

38

`ScopeManager.active` is documented as a feature used to get the current span. Perhaps it is a relic from the previous design. It tempts people to call close on it eventhough...