Adrian Cole

If you don't mind, please move some of the logic inlined into ci.yml into build-bin, with a README and RELEASE.md like the other projects. Also, if you can, please change...

add support for Elasticsearch Service on AWS

12

Zipkin 1.12 supports http transport and also hosted thanks to @sethp-jive. I'm sure folks will soon ask about the dependencies job. Most code in this repo isn't shared because the...

update to Spark 3.0 and JDK 11

10

We can't move to JDK 11 until the following is sorted https://issues.apache.org/jira/browse/SPARK-24421

zipkin-reporter-brave implementation has a sneaky dependency on zipkin2

1

I noticed that zipkin-reporter-brave still has a dependency on io.zipkin.zipkin2:zipkin because AsyncReporter and Sender extend zipkin2.Component among other things. AsyncReporter ```java import zipkin2.Call; import zipkin2.CheckResult; import zipkin2.Component; import zipkin2.Span; import...

``` [ERROR] zipkin2.reporter.AsyncReporterTest.messageTimeout_flushesWhenTimeoutExceeded Time elapsed: 0.043 s

Right now, it is required to use JSON when using brave's direct encoder. ``` Caused by: java.lang.IllegalArgumentException: Encoder doesn't match Sender: JSON PROTO3 at zipkin2.reporter.AsyncReporter$Builder.build(AsyncReporter.java:201) at zipkin2.reporter.brave.AsyncZipkinSpanHandler.(AsyncZipkinSpanHandler.java:152) at zipkin2.reporter.brave.AsyncZipkinSpanHandler$Builder.build(AsyncZipkinSpanHandler.java:147) at...

Add a disruptor based async reporter

12

We can calculate the size of a span without serializing it. We should be able to make an async reporter that defers serialization, but still allows us to drop spans...

Potential loss of data on JVM termination

3

_From @wjase on May 2, 2018 1:2_ Saw a warning from one of our Spring Artefacts on shutdown: 04 Apr 2018 12:36:34,299] WARN [requestId=] [loader.WebappClassLoaderBase]: The web application [XXX] appears...

From https://github.com/yschimke/oksocial/pull/255#issuecomment-317329218 From @yschimke: > Generally seems like having a URI for the Zipkin sink would be a useful feature for Brave. e.g. https://github.com/rsocket/rsocket-java/blob/1.0.x/rsocket-core/src/main/java/io/rsocket/uri/UriTransportRegistry.java Personally, I've thought about this sometimes....

Senders like `UrlConnectionSender` are blocking. We could add a decorator to make them not blocking, ex by using an executor. Rough sketch.. ``` java sender = withConcurrency(10, URLConnectionSender.create("http://localhost:9411/api/v1/spans")); ```