Adrian Cole

Results 2046 comments of Adrian Cole

so the thinking is.. I wonder.. if for data sets that naturally fit the heap-per-shard guidance at hourly or less, then putting that data in hourly should make more sense...

Literally, the default lookback is 1 hour, and currently, it will grab a day or possibly 2 if just past midnight, to form a query with. This is probably why...

at any rate we could put a branch up and see how it goes. If isn't helpful we wouldn't do it, but for some sites this could be an easy...

PS I opened this because I think I was the one who came up with the hour search default :) https://github.com/openzipkin/zipkin/issues/2772

I'm swamped in my new world of wasm, so won't be able to chime in or help support this. Folks currently on the show might decide differently than my previous...

For cassandra, see also * https://github.com/micrometer-metrics/micrometer/issues/1397 * also we're way overdue in upgrading to driver 4.. there's an issue somewhere. here's a related one from boot https://github.com/spring-projects/spring-boot/issues/18621

@tacigar I will be busy next couple days at least, possibly all week. I made a design here to correct the counts. Let me know if you have cycles to...

PS I overcomplicated the algo I think. With the special case of the root span localEndpoint.serviceName needing to be counted regardless, all we have to do is count dependencyLink.child where...

hah yeah I understand. I think I made the logic look more scary and the lines describing it is likely more than the lines in code. I'll take this on

this would need to become more popular and also with clear ownership as last time it became abandoned and we had to remove it #510