Adrian Cole

in `.github/CONTRIBUTING.md` there's this `./mvnw com.mycila:license-maven-plugin:format` I corrected the problematic license in master, but you can run it again after rebase anyway.

``` [INFO] ------------------------------------------------------- [INFO] Running zipkin2.elasticsearch.integration.ITElasticsearchStorageV6 2020-10-22 08:05:47:143 [main] WARN org.testcontainers.utility.RegistryAuthLocator - Failure when attempting to lookup auth config (dockerImageName: testcontainers/ryuk:0.3.0, configFile: /home/travis/.docker/config.json. Falling back to docker-java default behaviour. Exception...

The only way to do this is somewhat basic.. put said file in front of the classpath!

in the case of docker you'd overwrite the file at /zipkin/cassandra-schema-cql3.txt doing arbitrary upgrades could be dodgy. there's careful logic about the upgrade, and it checks for very certain things...

we could probably handle replication factor as an ENV variable as we do in elasticsearch, and leave it at that for now.

I would recommend seeing if this can be merged because we should release zipkin soon due to code drift between armeria here and what's used in zipkin-gcp (possibly also zipkin-aws)....

sorry I meant cut a patch

sorry about the late comment. @shakuzen's note was asking about if data would be valid if there's no timestamp based on the notes in our docs about it. It is...

thinking about jbender for this http://blog.paralleluniverse.co/2016/03/30/http-server-benchmark/ https://github.com/pinterest/jbender

@anuraaga did the bulk of this with testcontainers. I think the general process could be lifted by another into multi-node somehow https://github.com/openzipkin/zipkin/blob/master/benchmarks/src/test/java/zipkin2/server/ServerIntegratedBenchmark.java