Adrian Cole

Results 2050 comments of Adrian Cole

Thanks tons for the insight, @mosesn! hope the vacation was a nice one. @komsit37 does something like this work for you? ``` -Dcom.twitter.finagle.util.loadServiceDenied=zipkin.finagle.http.HttpZipkinTracer ```

there's some flake risk in the test... https://github.com/openzipkin/zipkin-finagle/blob/master/kafka/src/test/java/zipkin2/finagle/kafka/KafkaZipkinTracerIntegrationTest.java#L96 but the double-drop count is interesting.. I think failsafe isn't setup correct. Probably we should rename things `*IntegrationTest` to `IT*` and fix...

options is probably pre flight check for CORS. incidentally brave has no default sampling policy.. sleuth has a whitelist but not something for methods I think. On Wed, 3 Oct...

also trying haystack UI I noticed they have some pre canned filtering stuff. not saying related or not but it is neat. might relate to an outstanding Cassandra issue where...

sgtm @llinder wdyt? On Thu, Oct 4, 2018 at 9:46 PM Eirik Sletteberg wrote: > OPTIONS requests usually doesn't hit the application at all, they are > handled by whatever...

hah cool! the trick will be that since the build has _2.12 in it you will need to hack slightly to replace that with _2.13 to run tests only on...

In the current code, before we send a request, we add the trace id, like `X-B3-TraceId: 9d30188d40a191d3`. Let's say we started a stopwatch at the same time. If we added...

Uuid format isnt B3 compatible, so I guess the root concern here is to support an alternate propagation format (knowing it wont be compatible with libraries that use B3) https://github.com/openzipkin/b3-propagation...

Just thinking this through and I have a couple thoughts one is tangental. If we had a custom means for trace id format, we would need to allow someone to...

playing devil's advocate: do we want to fully use CPUs in the exporter side, or is there an advantage to tying up only one goroutine on encode? Are there benefits...