Adrian Cole
Adrian Cole
cc @openzipkin/core
Vague might not be the best word as we literally say what is available (though missing that activemq is also there). Want to copy/pasta in the missing ActiveMQ, and then...
This feels easier to do in a PR, but taking a stab: Zipkin server bundles extension for span collection and storage. By default spans can be collected over ActiveMQ, gRPC,...
See https://github.com/openzipkin/zipkin/issues/1074 for possible drift in the jar name of the scala zipkin-query-service
maybe we can have a sidebar link to the api, and also use it in context of http://zipkin.io/pages/data_model.html
cc at least @chimericalidea @kristofa @abesto @mikewrighton @michaelsembwever
In finagle, they say "none means we defer decision to someone further down in the stack." https://github.com/twitter/finagle/blob/develop/finagle-core/src/main/scala/com/twitter/finagle/tracing/Id.scala#L154
Looks like this is used in case the sampler failed or something? https://github.com/twitter/finagle/blob/fc321f804a22a695ec419902505c8509ffbd594d/finagle-zipkin/src/main/scala/com/twitter/finagle/zipkin/thrift/Sampler.scala#L80 @mosesn any more context on sampled = None
I think this is more an encoding issue in the fixed-length binary encoding of the Trace Id https://github.com/twitter/finagle/blob/fc321f804a22a695ec419902505c8509ffbd594d/finagle-core/src/main/scala/com/twitter/finagle/tracing/Id.scala#L103 Absence of header as being the same as don't sample might take...
Well like you said, if we make it false unless specified, we imply a strict coupling of id provisioning and sampling. Right now, clients like a browser plugin can send...