Adrian Cole

Results 2050 comments of Adrian Cole

copying in @sbc100 as per https://github.com/WebAssembly/spec/issues/1428 I'm gathering there's a sense that compatibility is a solved or nearly solved topic here. I am not trying to be problematic, but I...

@dschuff thanks for the consideration. Indeed the dominant issue I've found is sharing an implementation being the workaround to a gap in a spec, or even as a substitute for...

It seems the mode can't be read back by any of the functions defined here (e.g. not by [stat](https://github.com/WebAssembly/wasi-filesystem/blob/main/wasi-filesystem.md#-stat)), which makes less edge cases to describe for read-back. I would...

some files are virtual, ex backed by byte buffers and whatnot. others indeed use embed.FS, so we can only use *syscall.Stat_t on real files. As wasm is supposed to be...

my 2p is that this is both an expensive requirement, and not a very portable one wrt how files are supplied in wasm. It assumes direct plumbing to real files,...

fyi in benchmarks, using real files measures an order of magnitude slower for a small directory listing vs embedded FS. We'll implement what's needed, defensively, but generally speaking the more...

I don't think having the host resolve ".." will work. In current practice, the current working directory is tracked in guest code, not host code. Lacking any ability to hook...

I'll track this personally as I was unaware of this being targeted for preview1 and I'm sure others are unaware also

apologies @yoshuawuyts for putting words in your mouth. I re-did the description to quote instead of summarize. I am actually confused and I believe this spec can clarify its intent.

agreed. I don't think the `injects` attribute should be magically also a provider.