wasi-threads icon indicating copy to clipboard operation
wasi-threads copied to clipboard

change module name to wasi_snapshot_preview1

Open codefromthecrypt opened this issue 2 years ago • 2 comments

I came across below from rust-lang making a triple wasm32-wasi-preview1-threads

That's not right, wasi-threads is an extension to the Wasi Preview 1 specification which adds support for threads. That rationale was been clearly described in the https://github.com/rust-lang/compiler-team/issues/574. The only thing that's changed since is that https://github.com/rust-lang/compiler-team/issues/607 has been accepted, but that doesn't change the relationship between the base target and the threads extension. Since the compiler team has already accepted that rationale, it doesn't seem particularly productive to relitigate that in this PR

I am probably wrong, but I interpreted this as wasi-threads being an extension like the socket ABIs (sock_accept etc), which was added after the fact to wasi_snapshot_preview1. Can you clarify the position on this. Particularly, if this is a part of the wasi_snapshot_preview1 or not, and if this is intentionally in witx or will be converted to component model?

codefromthecrypt avatar Jul 13 '23 00:07 codefromthecrypt

I'll track this personally as I was unaware of this being targeted for preview1 and I'm sure others are unaware also

codefromthecrypt avatar Jul 13 '23 00:07 codefromthecrypt

apologies @yoshuawuyts for putting words in your mouth. I re-did the description to quote instead of summarize. I am actually confused and I believe this spec can clarify its intent.

codefromthecrypt avatar Jul 13 '23 07:07 codefromthecrypt