Shelley Vohr comments

Results 509 comments of


                                            Shelley Vohr

[Bug]: Uncaught illegal state exception and renderer crash with node immediates and closing child window

@markh-discord it's on my near-term todo list!

[Bug]: WCO on a high-DPI display with 175% scaling has incorrect height

@indutny-signal do you also notice this with Chromium itself?

[Feature Request]: Document webcontents.on('close')

@nornagon what do you think?

[Bug]: webview's visibilitychange event fired accidentally when webview or its parent element's style(display none, height 0 or visibility hidden) changing

Thanks for reporting this and helping to make Electron better! Because of time constraints, triaging code with third-party dependencies is usually not feasible for a small team like Electron's. Would...

Error: incompatible architecture issue while run the application

What version of Node.js are you using?

crypto: expose OPENSSL_IS_BORINGSSL constant

@tniessen what do you think you'd prefer?

crypto: expose OPENSSL_IS_BORINGSSL constant

@tniessen yes this works for Electron as-is!

crypto: expose OPENSSL_IS_BORINGSSL constant

@tniessen sorry for late reply but your link above is correct - it's not assigned a value. The compiler will look for the `#define` existing and make a decision based...

Can't build on windows because rewrapper_windows.cfg doesn't exist in buildtools of chromium src

@xyloflake are you trying to build regular chromium? We patch Electron to use an external config and so the required configs don't exist in regular Chromium. If you want to...

Can't build on windows because rewrapper_windows.cfg doesn't exist in buildtools of chromium src

@xyloflake did you sync properly prior to building?