Shelley Vohr

Results 509 comments of Shelley Vohr

@zhaozhongyu the version you reported this on is no longer supported. See [this reference](https://www.electronjs.org/docs/latest/tutorial/electron-timelines) for currently supported versions. Please confirm that your issue occurs on currently supported versions for us...

@zhaozhongyu does this also happen with Chrome itself?

@nornagon can you confirm if this is newly intended behavior after the `NonClientHitTest` implementation change?

@pacocoursey yes - it's on my personal docket and being actively worked on :)

@kyrylo-hrechykhin @zcbenz Blink assumes that all `Contexts` come with a `ScriptState` across the board, which is what's ultimately causing this issue. It's why we initially deprecated vm in the renderer...

@gpetrov ~this restriction/deprecation has existed in Electron for nearly a dozen versions - were you not seeing this before with the same userland code~? It'd help if you provided a...

@gpetrov a repro from you with dockerode would still be helpful! Some preliminary research shows this seems to affect vm scripts run after `window.open('')` specifically with no url.

Got a preliminary fix up: https://github.com/electron/electron/pull/37506 cc @zcbenz

@gpetrov do you have a more reproducible sample than that? given it doesn't run as-is i want to make sure i'm checking the right thing against the fix!

@gpetrov great news: Same bug - no error on my fix branch