Christopher Hesse

Results 58 comments of Christopher Hesse

What version of python are you using?

It looks like you need to have a function like `generate_test_level`: https://github.com/openai/coinrun/blob/master/coinrun/coinrun.cpp#L675 You should start with passing in exactly the existing test level: https://github.com/openai/coinrun/blob/master/coinrun/coinrun.cpp#L100 and making sure it works, then...

Please post the versions of baselines and version of gym that you are using.

How do your results compare to http://htmlpreview.github.io/?https://github.com/openai/baselines/blob/master/benchmarks_atari10M.htm?

Assuming this won't be changed in `urllib3`, is there an easy way to ensure a file has been completely read before calling `release_conn()`? I think there would be a performance...

I saw this error again from some tests. It still seems rare, but it's causing test failures. So looking at `is_connection_dropped`, it handles the case where someone closed the connection...

I am able to get the same error by doing: ``` resp._connection.sock.close() resp.release_conn() ``` But I don't believe any of my actual code accesses `_connection`, of course.