Chris Ramón

Results 11 issues of Chris Ramón

#### Overview - Built on top of: https://github.com/graphql-go/graphql/pull/274 - closes: https://github.com/graphql-go/graphql/issues/170 #### Test plan - `go test ./...`

#### Overview - graphql: adds `PanicHandler` type. - graphql: adds `Params.PanicHandler` field. - executor: calls PanicHandler when there's a panic while resolving a field. - closes: https://github.com/graphql-go/graphql/issues/243 - built on...

#### Overview - Upstream related PR: https://github.com/graphql-go/graphql/pull/428 - This is a WIP tracing support

#### Actual Currently the extensions component defined in: https://github.com/graphql-go/graphql/blob/58689e0742f217137ac0c82b16e2d658e0cc1853/extensions.go#L32-L33 Contains methods that are named in a way that could be clearer, for example: https://github.com/graphql-go/graphql/blob/58689e0742f217137ac0c82b16e2d658e0cc1853/extensions.go#L40-L41 ^ It is not clear if...

#### Actual Currently some of the `Components` do not have code comments. #### Expected We want to add code comments for better maintainability to the following `Components` if not present:...

#### Actual Currently the function: `ParseValue` from the file: `language/parser/parser.go` is deprecated. #### Expected We want to remove the `ParseValue` function since is deprecated.

#### Details - `.circleci`: Updates go version. #### Test Plan - :heavy_check_mark: Tested that `circleci` works as expected via GitHub builds.

#### Details - Depends on: https://github.com/graphql-go/graphql/pull/718 - `types`: adds `Result.ErrorsJoined` method. - `graphql_test`: adds `Result.ErrorsJoined` 100& test coverage unit tests. - `.circleci/config.yml`: upgrades `circleci` go versions. Added in order to...

#### Current - Currently the test coverage of `github.com/graphql-go/graphql/definition.go` is at `(84.2%)`. #### Expected - We want to increase it up to 90%.

*Check sub-issues.*