graphql icon indicating copy to clipboard operation
graphql copied to clipboard

.circleci: updates go version

Open chris-ramon opened this issue 10 months ago • 3 comments

Details

  • .circleci: Updates go version.

Test Plan

  • :heavy_check_mark: Tested that circleci works as expected via GitHub builds.

chris-ramon avatar Apr 01 '25 16:04 chris-ramon

I'm getting to work. See my steps and track my cost here.

  • [ ] Wake on any new activity. I always see new activity while actively working. When paused, I'll only respond when tagged unless this box is checked.

mentatbot[bot] avatar Apr 01 '25 16:04 mentatbot[bot]

Hi @chris-ramon, thanks for updating the CircleCI configuration to use more modern Go versions!

I noticed a couple of things that might need attention:

  1. There's a mismatch between the Go version in go.mod (which specifies go 1.13) and the versions being tested in CI (1.22.0, 1.23.0, 1.24.0). Depending on your intent, you might want to update the go.mod file as well.

  2. The coveralls job still uses circleci/golang:latest image, while the other jobs use cimg/go:. For consistency, would it make sense to update the coveralls job to use the same image prefix?

Overall, these changes look good and will help keep the CI infrastructure up to date. Let me know if you'd like me to make any additional suggestions!

mentatbot[bot] avatar Apr 01 '25 16:04 mentatbot[bot]

Coverage Status

coverage: 92.048%. remained the same when pulling 5a1a6bbd23f910ee100dae16a731df5ed2e4f2fd on updating-circleci into 58689e0742f217137ac0c82b16e2d658e0cc1853 on master.

coveralls avatar Apr 01 '25 16:04 coveralls

Closing this one, we might update the CircleCI configuration in follow-up PRs.

chris-ramon avatar Sep 10 '25 22:09 chris-ramon