Chris Gyurgyik
Chris Gyurgyik
One thing that pops out now is that the resulting code after `from_ssa` is now littered with `x: = id __undefined`. Given that `x` is undefined at that point, we...
Cool! This is probably much cleaner than my approach. The end result is the same, having to define an `__undefine`. Couldn't this be removed with a pass before emitting code...
> Seems possibly reasonable to literally generate "fake" code for the hallucinated block… but it could be even simpler, I imagine to instead do it as part of the algorithm?...
> Isn't your `defined_analysis()` an over-estimate of the defined variables, so it will miss some cases? > > I believe the problem you're trying to solve: > > ``` >...
Huh, yeah good point. It produces the same SSA as your PR, but `defined` is a poor choice of terminology. Thanks for the insight. The way I thought of the...
No problem!
Since `bril` doesn't support logical operators (please correct me if I'm wrong), this should be OK to close?
> https://capra.cs.cornell.edu/bril/lang/core.html#logic Well that's embarrassing. I'll get a patch in for this.
Agreed with Adrian. I think this would be under the "Good First Issue" tag, for someone in the research group or someone just interested in Calyx. I think that tag...
The Terminator trait is used for the CIRCT Calyx [GroupDonePort](https://github.com/llvm/circt/blob/185b9c6d85ad3a81db1703702bf46f4ab63ea617/include/circt/Dialect/Calyx/CalyxStructure.td#L341-L364) as well.