celiala
celiala
TFTR! bors r=jbowens TestReplicaProbeRequest is a net new test failure - calling this unrelated to this PR (the only updates have been rebases)
TFTR! FYI @msirek that I'm removing `TestAutoStatsTableSettingsDisallowedOnOldCluster` -- please scream and shout if this should be kept! Removing `TestAutoStatsTableSettingsDisallowedOnOldCluster` since: - it was failing (expected "feature not available yet" error...
`TestLogic_external_connection_privileges` is failing all of https://github.com/cockroachdb/cockroach/pull/85937 , https://github.com/cockroachdb/cockroach/pull/85938 , https://github.com/cockroachdb/cockroach/pull/85939, so I'm going to assume that it's not related to changes in this commit. ``` off_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/external_connection_privileges:24: SELECT * FROM system.privileges...
TFTR! bors r=msirek
Digging into failing tests: - `pkg/sql/logictest/tests/fakedist/fakedist_test` is a known flake. - `github.com/cockroachdb/cockroach/pkg/ccl/kvccl/kvtenantccl: TestTenantSystemConfigUpgrade` seems to be legit fail (see below output). Although, it's not clear to me how this change...
There's now a net new test failure (didn't fail on previous runs?): `github.com/cockroachdb/cockroach/pkg/sql/ttl/ttljob`: `TestRowLevelTTLJobRandomEntries/one_column_pk_multiple_nodes` ``` ------- Stdout: ------- === RUN TestRowLevelTTLJobRandomEntries/one_column_pk_multiple_nodes ttljob_test.go:546: test case: ttljob_test.testCase{desc:"one column pk multiple nodes", createTable:"CREATE...
These tests seem to be consistently failing, could use some help fixing 😅 (feel free to take-over/add to this PR as needed, if easier :) ) 🔴 TestAdminRelocateRange (maybe @tobias?)...
> I took this over sent out a PR https://github.com/cockroachdb/cockroach/pull/86676 Thank you @arulajmani
closing in favor of https://github.com/cockroachdb/cockroach/pull/86676
@dt @irfansharif - I'm going to remove the version gates in multiple passes, but let me know if version gate removal + bumping minVersion needs to be done more atomically....