celiala
celiala
I meant to push the additional 8/10 version gate removals to a separate branch, but accidentally pushed to this PR: Since the 8/10 commits were also straight-forward removals, I will...
TFTRs! bors r+ 8/12 Update: These version gate removals were reverted (removed from this PR) to pass tests. To be addressed separately (future PRs): - storage: EnablePebbleFormatVersionBlockProperties - sql: RowLevelTTL...
TFTR! FYI @AlexTalks that I'm going to remove `TestAutoStatsTableSettingsDisallowedOnOldCluster` -- please scream and shout if this should be kept! Removing `TestAutoStatsTableSettingsDisallowedOnOldCluster` since: - it was failing (expected "feature not available...
`TestLogic_external_connection_privileges` is failing all of https://github.com/cockroachdb/cockroach/pull/85937 , https://github.com/cockroachdb/cockroach/pull/85938 , https://github.com/cockroachdb/cockroach/pull/85939, so I'm going to assume that it's not related to changes in this commit. ``` off_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/logictest/testdata/logic_test/external_connection_privileges:24: SELECT * FROM system.privileges...
TFTR! bors r=AlexTalks
Note that this passes essential CI but is failing extended CI for these tests: `github.com/cockroachdb/cockroach/pkg/kv/kvserver`: - `TestReplicateQueueShouldQueueNonVoter` - `TestTruncateLog` - `TestTruncateLog/loosely-coupled=false` Hopefully the team can give guidance as to whether...
TFTR! bors r=shralex
Removed https://github.com/cockroachdb/cockroach/pull/85854 - PebbleFormatBlockPropertyCollector - PebbleFormatSplitUserKeysMarked Addressed in https://github.com/cockroachdb/cockroach/pull/85777: - kvserver: ProbeRequest, - security,pgwire: SCRAMAuthentication, - server: UnsafeLossOfQuorumRecoveryRangeLog, - kvserver: AlterSystemProtectedTimestampAddColumn - backupccl: EnableProtectedTimestampsForTenant - DeleteCommentsWithDroppedIndexes - sql/catalog: RemoveIncompatibleDatabasePrivileges -...