Christian Diener

Results 310 comments of Christian Diener

Sure go ahead. The `Object` class is implemented in `core/object.py`. Would be great if you could also add a test as well. You can add me as a reviewer for...

This has derailed a bit into discussing the new annotation format. The original issue has been fixed by enforcing the schema.

Might be related to https://github.com/opencobra/cobrapy/issues/736 but would need a bit more diving into...

Is BIGG still alive? It looks like it has been abandoned at this point... The easiest solution would still be for them to update the universal model...

I mean we could just convert the annotations in the JSON to the new standard and provide a repaired one then.

As a workaround, I added a fixed version to [our wiki](https://github.com/opencobra/cobrapy/wiki/BIGG-Universal-Model).

Thanks for that. There is a lot of great stuff in here. I was confused about the user-defined constraints though. The code basically reinvents optlang Constraints. Also it seems like...

> I currently don't have much knowledge of the solvers of COBRApy. Can we somehow get to know if a same constraint is already present in the model? Sure that...

Yes definitely. I would be particularly interested in reductions that: - maintain all original imports/exports - maintain the objective so basically all internal reactions can be lumped as long as...

The [JSON spec](https://tools.ietf.org/html/rfc7159#section-6) does not allow infinity values so those should be converted to `null`.