Cédric de Saint Léger

Call-time pass-by-reference is deprecated

7

I am getting some PHP Errors as you cannot pass references in function like call_user_function() and call_user_function_array() anymore. It was a warning in PHP5, and it errors out in 5.3....

SQLStore still makes use of PEAR DB

1

It is clearly stated in the class comments that PEAR can be replaced with a class extending DatabaseConnection. This is for good, I don't have PEAR installed on my system...

is_a() is deprecated, use instanceof instead !

2

There are 5 matches in Consumer.php and 9 matches in Server.php. 1 match in AX.php. They should all be replaced by instanceof operator as of PHP 5. This currently results...

It'd be better to have the initial Yadis discovery running in a separate method from the begin() method. That way you could still use this new discovery() method to check...

Why not use curl instead ?

5

Simple change... A lot more compatible, and far less compatibility issues than file_get_contents (allow_url_fopen must be on, other issues I couldn't even sort out on fetching remote content via file_get_contents()...

State problem

2

There is an issue with how states behaves. Luckily, it is easy to fix. This is the problem : ``` AutoModeler::factory("user", 1); ``` Will actually load the object. So the...