php-openid icon indicating copy to clipboard operation
php-openid copied to clipboard

De-couple Discovery from the Begin() process in Auth_Openid_Consumer

Open ccazette opened this issue 15 years ago • 0 comments

It'd be better to have the initial Yadis discovery running in a separate method from the begin() method. That way you could still use this new discovery() method to check if the endpoint is valid without triggering the all authentication process. That would also allow to use a different discovery method.

A simple fix could be to rename have all the begin() logic in a discover() method, and have begin() calling this method and then calling beginWithoutDiscovery() if the endpoint is found or returning NULL if not.

ccazette avatar May 07 '10 13:05 ccazette