Carlos Serrano

Results 14 comments of Carlos Serrano

This change looks good to me. @jonchurch CI should stop failing if you rebase your branch against master.

@wesleytodd some repositories are still using [travis](https://github.com/carpasse/etag) Is it ok to migrate them to github actions respecting the specified Node.js versions?

Not sure when they will enforce the change but there is a blog post from GitHub advising to migrate to node 20 on Github actions. https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ We've are already seen...

Not sure why the build failed to run. It works on my fork https://github.com/carpasse/basic-auth/actions/runs/9074203811

Action passing https://github.com/carpasse/resolve-path/actions/runs/9282562761

Hi @blakeembrey This isn't a direct port because the priority was maintaining consistency with all other GH actions in the express, pillarjs, and jshttp organizations. The change in Mocha was...

May be worth mentioning that the travis build is not working at the moment https://app.travis-ci.com/pillarjs/resolve-path

I've refactored the CI pipeline task, and I believe it's now more closely aligned with what Travis CI pipeline did. The key differences from the Travis CI pipeline are: -...

It seems that `this.path` is being set to `undefined` because we can't determine what `path` the `Layer` is matched against until runtime. Let me explain my thought process: Layers are...

@IamLizu I believe the `path` argument passed to the `Layer` constructor represents either a list of handler paths (as an array) or a single string. To improve clarity, It may...