resolve-path icon indicating copy to clipboard operation
resolve-path copied to clipboard

Migrate ci pipeline to github actions

Open carpasse opened this issue 1 year ago • 4 comments

Agreed to migrate to GH actions in https://github.com/expressjs/discussions/issues/229

The new ci action and README.md changes are based on the respective files in accepts repository

carpasse avatar May 29 '24 08:05 carpasse

Action passing https://github.com/carpasse/resolve-path/actions/runs/9282562761

carpasse avatar May 29 '24 08:05 carpasse

Hi @blakeembrey

This isn't a direct port because the priority was maintaining consistency with all other GH actions in the express, pillarjs, and jshttp organizations. The change in Mocha was made to use a more modern version compatible with the latest Node.js. Additionally, replacing Istanbul with NYC aligns with how coverage is tracked in all other repositories.

The pipeline removes ESLint for Node.js versions 10 and below, which is consistent with previous actions. I can add it to the install step if you prefer.

carpasse avatar Jun 03 '24 07:06 carpasse

May be worth mentioning that the travis build is not working at the moment https://app.travis-ci.com/pillarjs/resolve-path

carpasse avatar Jun 03 '24 07:06 carpasse

I've refactored the CI pipeline task, and I believe it's now more closely aligned with what Travis CI pipeline did.

The key differences from the Travis CI pipeline are:

  • Added missing Node.js versions to the test matrix.
  • Stopped linting for Node.js versions < 12 (previously < 6).
  • Switched to NYC for test coverage collection, replacing Istanbul.

@blakeembrey can you please take a look and let me know if there’s anything you think I should change?

carpasse avatar Aug 17 '24 07:08 carpasse