Carlos Alexandre comments

Results 33 comments of


                                            Carlos Alexandre

The "count" value depends on resource attributes that cannot be determined until apply

I'm having the same problem here inside a module. I can confirm that the hack provided [here](https://github.com/gavinbunney/terraform-provider-kubectl/issues/58#issuecomment-718174177) does not work either inside a module - I have not tested it...

The "count" value depends on resource attributes that cannot be determined until apply

I managed to build a hacky workaround that might work for most of you guys... Basically I replaced the `count` source using other terraform's built-in functions to fetch the document...

The "count" value depends on resource attributes that cannot be determined until apply

@jodem it doesn't happen always, that's why some folks are reporting the issue.. I've used this module for at least one year, and it never happened to me, until today...

The "count" value depends on resource attributes that cannot be determined until apply

> Ok @calexandre thanks for the clarification, it's a bit scary. Thanks also for providing an elegant hack to mitigate the issue. Thanks! I don't know about the "elegant" part...

feature request: validate on the content of the last comment added

> We are trying to implement a worklow where we want a comment to be the trigger for the deployment, like a bot (ex: Atlantis). This would actually be really...

feature request: validate on the content of the last comment added

> @calexandre I think it's a great use case, maybe even only validate the content if the `author` matches the settings (terraform in this case). I personally don't think I'll...

feat: Added support for GitHub app

@bryantbiggs @antonbabenko I've helped @abalcobia with the latest changes. Can you guys review please?

feat: Added support for GitHub app

Thanks for the review @bryantbiggs! we'll make the requested changes asap 👍