Carlos Alexandre

Results 33 comments of Carlos Alexandre

@bryantbiggs we've included instructions on how to generate a github app. We've also added a note stating that using GitHub PATs is no longer recommended (despite being still supported). Let...

@bryantbiggs we've updated the PR with the latest changes from the `master`. Can we get this merged on the master, or is something missing?

@bryantbiggs sorry to bother, but do you have any updates on this? We've updated the branch to the latest commit on master...

rebased and squashed the commit history

Well, it depends if you want to keep supporting PAT based installations... Do you want us to remove all PAT references?

> I don't think thats the way to look at it - there are two avenues: > > 1. User elects to use GitHub PAT (and only PAT) > 2....

Oh, that must have slipped on a previous rebase... I will look into that in a moment! Thank you for pointing it out 👍

Just note that it is not possible to configure the github provider using both approaches, you either need to choose the PAT of the APP approach, or use two providers...

@bryantbiggs I re-added the `github_token` variable on all modules that require `github-repository-webhook` to make this work for both scenarios. Please note that only Atlantis should benefit from the github app...

> > Just note that it is not possible to configure the github provider using both approaches, you either need to choose the PAT of the APP approach, or use...