Benji Franck

Results 43 comments of Benji Franck

Has this issue already been resolved in the `alpha` branch? šŸ¤” I couldn't replicate it in my playground. When I added the following to my Web playground... `` I can...

Testing the new variant styling... | | color | dark | nocolor | light | inverted | destructive | |--------|--------|--------|--------|--------|--------|--------| | **Default** | | | | | | | |...

Here's how the inverted variants look on `alpha`... ![inverted variants on alpha](https://github.com/GovAlta/ui-components/assets/1479091/d72fe0c4-dca4-4658-8610-2874650304c9) This PR changes their styling all to `light`: ![inverted variants on branch](https://github.com/GovAlta/ui-components/assets/1479091/0c56706a-0bb4-4854-aa92-fd99ececaa71) I checked with @twjeffery who confirmed...

### Testing the acceptance criteria - [x] Indicate `nocolor` it is deprecated - [x] Don't change icon color on focus - [x] Border radius is `m` #### Light & inverted...

My local tests pass. ![image](https://github.com/GovAlta/ui-components/assets/1479091/118f6c02-8bd8-45d5-bbc6-33299709f035)

@lizhuomeng71 Yes, the old `inverted` property does the same job as the new `light` variant: lighten the icon to work on dark backgrounds. I kept the `inverted` property with a...

> for angular, the error message should read goa-icon-button instead of GoAIconButton > > ![image](https://private-user-images.githubusercontent.com/7528736/330207644-2d2ba176-85fa-497a-8ec4-d7750942df4f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTU2OTY4MDMsIm5iZiI6MTcxNTY5NjUwMywicGF0aCI6Ii83NTI4NzM2LzMzMDIwNzY0NC0yZDJiYTE3Ni04NWZhLTQ5N2EtOGVjNC1kNzc1MDk0MmRmNGYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDUxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA1MTRUMTQyMTQzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWUxNGJjOGYwNDVmMjE4NzQ3MDZhMWMwMTFlNWM0NjE4YjIzZmM3MzE2ZjA4YWZiM2ZjYzBlZWNmOTQ3Y2M1NyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.0I2Nu84VpiOP6fpYJArWgSNYQKVJmN6F48qVDQ0gld8) @lizhuomeng71 I've updated my PR to use `goa-icon-button` instead of `GoAIconButton` in the console warnings.

D'oh! I forgot to push my local changes. Now I've pushed my updated console warnings.

I also noticed this issue when I was working on my [PR](https://github.com/GovAlta/ui-components/pull/1777) to fix https://github.com/GovAlta/ui-components/issues/1768. The issue is that we add spacing by putting a fixed [minimum height](https://github.com/GovAlta/ui-components/pull/1777/files/bbe3412658d4896edc3e3cfd9d0e2576cdc41024#r1563189413) on the...

@twjeffery Odd. I ended up removing the bottom margin from my PR because I thought it was already fixed. https://github.com/GovAlta/ui-components/pull/1777#discussion_r1563189413 I checked in `alpha` and we're still using a min...