Benji Franck
Benji Franck
Has this issue already been resolved in the `alpha` branch? š¤ I couldn't replicate it in my playground. When I added the following to my Web playground... `` I can...
Testing the new variant styling... | | color | dark | nocolor | light | inverted | destructive | |--------|--------|--------|--------|--------|--------|--------| | **Default** | | | | | | | |...
Here's how the inverted variants look on `alpha`...  This PR changes their styling all to `light`:  I checked with @twjeffery who confirmed...
### Testing the acceptance criteria - [x] Indicate `nocolor` it is deprecated - [x] Don't change icon color on focus - [x] Border radius is `m` #### Light & inverted...
My local tests pass. 
@lizhuomeng71 Yes, the old `inverted` property does the same job as the new `light` variant: lighten the icon to work on dark backgrounds. I kept the `inverted` property with a...
> for angular, the error message should read goa-icon-button instead of GoAIconButton > >  @lizhuomeng71 I've updated my PR to use `goa-icon-button` instead of `GoAIconButton` in the console warnings.
D'oh! I forgot to push my local changes. Now I've pushed my updated console warnings.
I also noticed this issue when I was working on my [PR](https://github.com/GovAlta/ui-components/pull/1777) to fix https://github.com/GovAlta/ui-components/issues/1768. The issue is that we add spacing by putting a fixed [minimum height](https://github.com/GovAlta/ui-components/pull/1777/files/bbe3412658d4896edc3e3cfd9d0e2576cdc41024#r1563189413) on the...
@twjeffery Odd. I ended up removing the bottom margin from my PR because I thought it was already fixed. https://github.com/GovAlta/ui-components/pull/1777#discussion_r1563189413 I checked in `alpha` and we're still using a min...