Add margin to bottom of checkbox description
Acceptance Criteria:
- Add
--goa-space-mmargin to the bottom of the checkbox description when the property is enabled - This additional spacing should not be there when the checkbox description is hidden
Background:
This issue is in response to the issue reported by bug #1519. This fix will not elevate this issue but working on this issue made apparent this spacing issue present with the checkbox component.
I also noticed this issue when I was working on my PR to fix https://github.com/GovAlta/ui-components/issues/1768. The issue is that we add spacing by putting a fixed minimum height on the checkbox instead of bottom padding.
In my PR, I remove the minimum height and use bottom padding instead.
This is the same approach that we have for radio buttons.
@Spark450 Does this solve the issue? Are there any other situations that I should be considering?
@bdfranck This looks fixed to me! Awesome! Is this one good to close then?
@twjeffery Odd. I ended up removing the bottom margin from my PR because I thought it was already fixed. https://github.com/GovAlta/ui-components/pull/1777#discussion_r1563189413
I checked in alpha and we're still using a min height instead of a bottom margin on the checkbox:
We should keep this issue open until it's resolved.