ui-components icon indicating copy to clipboard operation
ui-components copied to clipboard

Add margin to bottom of checkbox description

Open Spark450 opened this issue 1 year ago • 1 comments

Acceptance Criteria:

  • Add --goa-space-m margin to the bottom of the checkbox description when the property is enabled
  • This additional spacing should not be there when the checkbox description is hidden

Background:

This issue is in response to the issue reported by bug #1519. This fix will not elevate this issue but working on this issue made apparent this spacing issue present with the checkbox component.

Spark450 avatar Apr 11 '24 16:04 Spark450

I also noticed this issue when I was working on my PR to fix https://github.com/GovAlta/ui-components/issues/1768. The issue is that we add spacing by putting a fixed minimum height on the checkbox instead of bottom padding.

In my PR, I remove the minimum height and use bottom padding instead.

image

image

This is the same approach that we have for radio buttons. image

@Spark450 Does this solve the issue? Are there any other situations that I should be considering?

bdfranck avatar Apr 15 '24 21:04 bdfranck

@bdfranck This looks fixed to me! Awesome! Is this one good to close then?

twjeffery avatar May 23 '24 00:05 twjeffery

@twjeffery Odd. I ended up removing the bottom margin from my PR because I thought it was already fixed. https://github.com/GovAlta/ui-components/pull/1777#discussion_r1563189413

I checked in alpha and we're still using a min height instead of a bottom margin on the checkbox:

image

We should keep this issue open until it's resolved.

bdfranck avatar May 23 '24 14:05 bdfranck