Bernardo Botella

Results 10 comments of Bernardo Botella

This PR needs further discussion @eliasdorneles

I like the one to fit them all approach. And, about the jinja template... What about adding the possibility of loading a text file from local disk/url?

@eliasdorneles What about always treating them as a "list of filters", just like we do with notifications. Of course, we would allow single filter configurations as we do now. Filters...

Loving that "filter composition" proposal. Will go with it.

We are not leaving clean env after tests. I realized it is a master problem, I'll fix that in other PR

@yifan-c Added the aggregation for cicle. Working example here https://app.circleci.com/pipelines/github/bbotella/cassandra-sidecar/19/workflows/593a195b-096f-4b38-95ad-5f6b425496f7/jobs/245

If we are going to disable constraints, should we add the if check to this line? https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java#L1009 ``` Validation.checkConstraints(metadata(), key); ``` And this? https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java#L1024 ``` checkClusteringConstraints(clustering); ```

Thanks everyone for the feedback and comments @jmckenzie-dev @Maxwell-Guo @smiklosovic ! I think I addressed all the comments that were left on the code. As per @jmckenzie-dev questions, let's go...

@Maxwell-Guo There is already tests covering the describe statement in the `CreateTableWithColumnCqlConstraintValidationTest` test class. Here: https://github.com/apache/cassandra/pull/3562/files#diff-bb537e06c36f3dc9cfb0d52cfcbd75b609b51f5696c13f93f467a4b9fc79f483R50 I like the suggestion for the autocompletion. I will look into it.