cassandra
cassandra copied to clipboard
CASSANDRA-20712 - disabling of constraints in CQLSSTableWriter
Thanks for sending a pull request! Here are some tips if you're new here:
- Ensure you have added or run the appropriate tests for your PR.
- Be sure to keep the PR description updated to reflect all changes.
- Write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
- Read our contributor guidelines
- If you're making a documentation change, see our guide to documentation contribution
Commit messages should follow the following format:
<One sentence description, usually Jira title or CHANGES.txt summary>
<Optional lengthier description (context on patch)>
patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>
The Cassandra Jira
If we are going to disable constraints, should we add the if check to this line? https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java#L1009
Validation.checkConstraints(metadata(), key);
And this? https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java#L1024
checkClusteringConstraints(clustering);