Bryan Boreham
Bryan Boreham
I did look at the latest code, and it doesn't seem any different in this respect - it still calls `Wait4()` to wait indefinitely.
Look at the stack traces - `exec` is calling wait and `reap` is calling wait.
However, reflecting on the `ps` output I saw, I wonder if the sub-process has not exited at all. From the docs I expect `cancel()` to kill it.
The code on master calls `defer cancel()` - how would that work on a timeout?
> It is potentially hiding memory leaks in the collector by cleaning up faster This is a misunderstanding. Go heap profiles only show what survived after the last garbage-collection. (Also...
OK how does this run CI for you and not for me?
In the logs of my failed run: ``` Using environment variables from project settings and/or contexts: CIRCLE_OIDC_TOKEN=**REDACTED** CIRCLE_OIDC_TOKEN_V2=**REDACTED** CIRCLE_PLUGIN_TEST=**REDACTED** ``` Your successful run: ``` Using environment variables from project settings...
Update: Grafana Labs has decided to move what they were using from this repo to https://github.com/grafana/dskit.
I don't recall any discussion. I think when this library started the `Server` didn't do much beyond set up two listeners. Could we re-use one of the existing parameters, e.g....
The reason for picking gogo/protobuf was performance: I would like to be confident that we are moving to one with equal or better performance. (It shouldn't be a massive ask...