Bryan Boreham comments

Results 1068 comments of


                                            Bryan Boreham

`Appender.Append` should return the appended labelset

I mean it would return an existing reference, if any, and create one if not. To be called before `Append()`. I guess that opens up a race where the reference...

Add a configurable stabilisation delay before resolving alerts

What's left to do here?

Add a configurable stabilisation delay before resolving alerts

At https://prometheus.io/docs/prometheus/latest/configuration/recording_rules/#rule I see it under "The syntax for alerting rules is:" Maybe you mean it should be on https://prometheus.io/docs/prometheus/latest/configuration/alerting_rules/. (Which I would agree with). Would you like to make...

Promtool: add http config support to query commands

Fuzzing issue #11810

Promtool: add http config support to query commands

Would you consider including `tsdb create-blocks-from rules`, which also performs queries ? (no pressure, just asking)

Promtool: add http config support to query commands

I think there is some general issue with CI - I've seen these error messages on other PRs. Didn't yet figure out what the issue is.

Discard Summary metrics

Ok that should be in a separate commit, probably a separate PR.

Clean up old metrics using metrics timestamp

Thanks for this - sorry nobody responded before now. I'd like to take more time to read through before merging.

Clean up old metrics using metrics timestamp

Do you want to take over the PR and resolve the comments I made?

Clean up old metrics using metrics timestamp

I have commented on #61. I don't have write access to this repo so can't close this PR.