Bryan Boreham
Bryan Boreham
Hello from the bug-scrub! This looks good, however we do ask for benchmarks for performance optimisations. > This is a bit tricky to benchmark Could you try running 10 or...
Pointers to `Time` here is not idiomatic Go, in my opinion. Adding a new method like `SeriesForAllTime` would be non-breaking. I think I’d be fine with the zero time meaning...
@saroshali-dbx are you likely to return to this, or shall we close it?
Very old issue; I assume this is resolved now.
What is the ordering? Can we get this: weave launch ... container attach to weave ... ecs-agent start ... weave discovers its peers ?
> [3. Weave needs to know at least one peer at launch time. would be addressed by https://github.com/weaveworks/weave/issues/1721, so long as you can `weave connect` the peers before trying to...
If you have a 1-node cluster then, effectively, the correct number of `weave connect`s have happened.
But you might want a way to have IPAM defer any allocation until you know the number of peers. Do note I'm trying to address the OP's point in a...
Yes. To give an example, suppose the order is (on host1): ``` 1. weave launch 2. 3. weave connect host2 4. weave connect host3 ``` then we want to be...
This came up in conversation today. Given OpenTelemetry has matured and adoption has increased I'm more OK with a breaking change.