Bryan Boreham

Results 1068 comments of Bryan Boreham

It's fine - we can "squash" them all together at merge time.

> Is it possible that api/v1/metadata is being populated BEFORE the metrics are being dropped by the config above? Yes. Metadata is associated with a "metric family" (just the name...

You don't think "the per-second average rate of increase", a few lines up, already covered it?

I notice in a similar previous issue @csmarchbanks said https://github.com/prometheus/prometheus/issues/7124#issuecomment-613634182 > At very low remote write volumes it is very easy to go through multiple batch send durations without new...

Best to comment on the PR within the PR itself.

I don't think that helps. In my example, Prometheus scraped 509 series every 5 seconds; I wanted it to send those 509 series without waiting 5 seconds. If I reduce...

Agreed, thanks for spotting the problem.

This seems workable, but I was rather confused for a while. I was unfamiliar with the `MarshalYAML` method, which is not expected to do any marshalling, but to return an...

Yes I can merge, was just waiting to see if anyone else had a view.