Bryan Boreham

I don't see any difference. Also, prombench data doesn't have any native histograms.

/prombench cancel

Thanks for this; seems a very reasonable idea. You don't mention it explicitly, so I will note that sorting is disabled during WAL replay. https://github.com/prometheus/prometheus/blob/52389647b2ab4e52d86c97089cf5f4260839f984/tsdb/head.go#L319 then fixed up at the...

I think the main people impacted by this are people using PromQL as a library outside of Prometheus. And I don't know who they are, broadly. Maybe @charleskorn, @fpetkovski ?...

Without it we have a circular dependency between `promql` and `promql/promqltest`.

> you had to introduce promql_test which looks an anti-pattern to me Some people hold that this is actually a best practice. It is described at https://pkg.go.dev/testing: > The test...

Responding to Marco's point about exporting internals, I added parameters to `NewTestEngine` which allow `TestEnablePerStepStats ` and `TestSetLookbackDelta` to be removed, exported the default to remove `TestGetMaxSamplesPerQuery`, and added `hasAtModifier`...

Also one more export: `KahanSum`, a function only used by a test. Perhaps should be named `TestKahanSum`. I think the feature can be tested instead via `sum_over_time`.

I have now removed all new exports from `promql` in this PR, except `NewTestQuery`. Also I renamed a new file `engine_internal_test.go` [since I read](https://medium.com/@matryer/5-simple-tips-and-tricks-for-writing-unit-tests-in-golang-619653f90742) that some people use this idiom....

Thanks for your contribution, however we need a "DCO sign-off" for your commit. The method is described here: https://github.com/prometheus/prometheus/pull/13994/checks?check_run_id=24269937908