Bryan Boreham

It just occurred to me: the caller might like to know if the results were truncated.

> You mean should I add a warning to the response if the results were truncated because of the limit? Sounds reasonable.

> Since we check for limits within the Next() loop, we don't really fetch all the series data? We do fetch all the labels though, but those are cheap enough...

BTW I added @rexagod as co-author in sign-off, since the original code came from #12823

This is working as defined. The [documentation](https://prometheus.io/docs/prometheus/latest/configuration/configuration/#relabel_config) says "keep: Drop targets for which regex does not match the concatenated source_labels." Feel free to submit a PR which makes the documentation...

Please supply a description, saying why you think we should do this. Also please follow this instruction from the PR template: - Please sign CNCF's Developer Certificate of Origin and...

OK, I see you're trying to fix an issue from 2017, with comments up to 2020. Please describe why this solution is correct. Assume I don't know what all the...

> Please describe why this solution is correct. Assume I don't know what all the flags to "chgrp" do. Please can you do this, in this PR. Don't ask us...

> > Please describe why this solution is correct. Assume I don't know what all the flags to "chgrp" do. > Sure, it changes the group ownership to 0 which...

Personal view: I'm unhappy with 1 minute. When you include scrape interval and evaluation interval it means any dashboard panels built from recording rules are around 1.5 minutes behind real-time,...