Denis Borzenko

Implementation gotcha: http: multiple response.WriteHeader calls

1

https://github.com/googollee/go-engine.io/blob/d38973698d3378fd1cf8c996a69dcdbccff54955/server.go#L146 Because of this line I am getting a warning in stderr (from the standard http package): ```http: multiple response.WriteHeader calls``` Underlying Gorilla's websocket [writes an error](https://github.com/gorilla/websocket/blob/b65e62901fc1c0d968042419e74789f6af455eb9/server.go#L151) to the responseWriter...

Unexpected multiple emits (multiple rooms joined)

7

https://github.com/googollee/go-socket.io/blob/101f99ce012b002ac8b85d901399054e2227d76b/broadcast.go#L105-L119 According to this code, if some socket is a member of multiple rooms, then it receives message multiple times. I think it's a bug.

Reimplement newBitboard to avoid string operations

2

Instead of building a string of "0"s and "1"s and then converting it, newBitboard now uses bit arithmetic to convert a map to a uint64. This avoids memory allocation and...

I've found you forgot to add «Track Remote Branch» to window menu (perhaps someone is needed; there's a hotkey hint). I suggest to ignore invalid branch names (`origin/master -> HEAD`...

New command Diff Branch to compare all files or single file of current branch to another branch