Denis Borzenko comments

Results 7 comments of


                                            Denis Borzenko

Implementation gotcha: http: multiple response.WriteHeader calls

Also, it seems that this is the reason of the googollee/go-engine.io#90 issue (with another version of std http package). As I can see, we can't determine in a proper way...

Unexpected multiple emits (multiple rooms joined)

I think, it is too hard to make a new map each time we want to broadcast. Instead I propose to join each socket to default room automatically (for example,...

Unexpected multiple emits (multiple rooms joined)

When you make a map per broadcast, you're using memory too (the same size). But there would be another memory allocation each time you want to broadcast. Also there are...

How can i disconnect client from server

Try this: https://github.com/googollee/go-socket.io/blob/101f99ce012b002ac8b85d901399054e2227d76b/conn.go#L20

Reimplement newBitboard to avoid string operations

@notnil, I'm sorry, it's my fault. There was a typo in the expectation. I've fixed it. Also we can see now, that test were run successfully on PR.

Avoid string operations/allocation in newBitboard

@notnil, here's a test (sorry :) ```patch diff --git a/bitboard_test.go b/bitboard_test.go index 0000000..3c0a55f 100644 --- a/bitboard_test.go +++ b/bitboard_test.go @@ -7,6 +7,11 @@ type bitboardTestPair struct { reversed uint64 } +type...

Diff/Merge on non-git files

@dpjohnst this feature request is about diffing non-git files (and directories) ;)