Jeremy Barton

CodeFormatter should remove redundant field initializers

1

``` public class CryptoStream { private int _InputBufferIndex = 0; } ``` `_InputBufferIndex` will already have the value 0, the initializer being there doesn't change anything.

``` public class CryptoStream { private byte[] _InputBuffer; } ``` `_InputBuffer` did not get rewritten to `_inputBuffer`.

In the event it is required for disambiguation or invoking an extension method it certainly should remain, but the [Coding style guidelines](https://github.com/dotnet/corefx/wiki/Coding-style) say "4. We avoid this. unless absolutely necessary.",...

Many of the files not yet moved from closed source to open in corefx have "using global::System;". Aside from "using System" being usually redundant due to the contained namespace chain,...

I haven't verified with a minimal repro, but based on cases where this has been seen it seems like ``` public bool SimpleProperty { [Pure] get { return false; }...

``` class Outer1 { class Inner { private object _couldBeReadonly; } } class Outer2 { class Inner { private object _couldBeReadonly; } } ``` This will only mark Outer1+Inner._couldBeReadonly as...

Running on Linux leaves terminal colors changed

2

After running BDN on Linux I see my terminal colors modified. SSH via PuTTY with xterm, .NET 6, BDN 0.13.2, Ubuntu 18.04. (Similar results were seen with xterm-256color) * A...

### Description All of the cryptographic factory methods that accept a string, such as `Aes.Create(string)` have been declared `[Obsolete]` with the SYSLIB0045 diagnostic code. ### Version .NET 7 Preview 7...

System.Text.Json failing some large file tests

25

https://dev.azure.com/dnceng/public/_build/results?buildId=1387876&view=ms.vss-test-web.build-test-results-tab&runId=40401306&resultId=194463&paneView=debug If I didn't know any better, I'd say "memory corruption". https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-59626-merge-ff748885001649f2ad/System.Text.Json.Tests/1/console.55b96e63.log?sv=2019-07-07&se=2021-10-17T15%3A49%3A24Z&sr=c&sp=rl&sig=jkQ9vlfitTdm9LAJkyCb4ZnZxrI5Gb%2F8qvt%2FSn0S27M%3D ``` Console log: 'System.Text.Json.Tests' from job ff748885-0016-49f2-ad26-20905cd95f3d workitem 0045d34b-f5a3-424a-8789-b58e57023e81 (osx.1015.amd64.open) executed on machine dci-mac-build-195 + ./RunTests.sh --runtime-path /tmp/helix/working/A15608F4/p...

### Description `ReadOnlySpan` in the .NET ecosystem is used for two different things, 1) a specific sequence of characters, often as a slice of a larger `System.String` instance, 2) a...