Bart Kamphorst

Results 13 issues of Bart Kamphorst

Github's [Primer.css](https://primer.style/css) has been added to gollum for styling (implemented in https://github.com/gollum/gollum/pull/1393). This issue is meant to track any styling issues that can be improved upon, but also as an...

improvement
CSS styling
help wanted

Gollum currently uses custom dialog modals (upload, rename, new). When the switch to Primer CSS has been merged, we should look into deprecated these custom modals for Primer's [Box--overlay](https://primer.style/css/components/box-overlay). At...

improvement
CSS styling

Just looking at a simple table, it occurred to me that we might want to style these similarly to our search bar, buttons, Footer and Sidebar, namely with rounded corners....

improvement
CSS styling

Issue https://github.com/gollum/gollum/issues/279 reported the possibility of edit collisions. Basic handling of edit collisions was implemented in PR https://github.com/gollum/gollum/pull/1349. The current behavior when collisions are detected is to show the user...

improvement
help wanted

My proposal is that all `path` and `dir` variables will be Pathname objects, and that `name` will remain a String.

enhancement

Adding a dark mode and being responsive to a client's day/night setting seems like a nice-to-have feature. If there's anyone willing to work on this, a PR would be welcomed.

feature
CSS styling
help wanted

Gollum currently still uses JQuery 1.7.2. We should see if we can update the library, since the latest release is already on 3.6.3. This might require some serious work though,...

Move clipboard.js to yarn to make it easier to update.

improvement

Some user interactions still rely on JQuery's `confirm`, such as when a user tries to delete a page (see screenshot). ![Screenshot 2022-12-27 at 11 34 33](https://user-images.githubusercontent.com/571173/209654143-1c89d1a1-e47e-476d-87e2-ac49d7fc6d0c.png) Once we have Primer...

improvement
CSS styling

Once we have updated Primer, we could replace `.dotted_spinner` and the custom `_spinners` scss with Primer's spinner component.

improvement
CSS styling