Bart Kamphorst
Bart Kamphorst
This dependency on `idn-ruby` also breaks JRuby support for [gollum](https://github.com/gollum/gollum). We too would appreciate it if `idn-ruby` were made optional.
I actually think changing the icon set can be so disruptive that it can warrant a major release. Not sure whether the changes to the actual icons are that big...
Hopefully, although we might run into other issues as well.
@dometto For the test suite, would you prefer `assert_equal 'Mordor/Eye-Of-Sauron.md', map[3].path.to_s` or `assert_equal Pathname.new('Mordor/Eye-Of-Sauron.md'), map[3].path`?
Do you mean `Benchmark`? ```ruby Benchmark.bm do |x| x.report { for i in 1..n; a = "1"; end } x.report { n.times do ; a = "1"; end } x.report...
@Naatan Any chance you'd be willing to open a PR for caching based on the work in your fork?
There's [this issue](https://github.com/primer/octicons/issues/240) about a `fill` option?
For reference, see [this PR](https://github.com/gollum/gollum/pull/1876) for discussion.